Minerals are solid, naturally occurring inorganic substances that can be found in the earth's crust. Minerals are naturally occurring, crystalline solids with specific chemical formulas.
All rocks except obsidian, coal, and amber are made of minerals. Obsidian is a volcanic rock made of glass. Coal and amber do not qualify as minerals because they are organic materials derived from plants. ( https://commons.wvc.edu/rdawes/basics/rocktypes.html)
Metals are elementary substances, such as gold, silver and copper that are crystalline when solid and naturally occurring in minerals. They often have the characteristics of being good conductors of electricity and heat, of being shiny in appearance and of being malleable.